Minimum bar - compile on Windows (containerd dependency) #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <[email protected]>
Contributor
|
I think #310 is working on this. |
Contributor
Author
Contributor
Author
|
Closing for now. Working around it in containerd in the interim pending #310 |
Member
|
thanks @jhowardmsft I'll rebase #310 and finish that work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
@icecrime - Minimum bar to even start looking at containerd. Containerd pulls in opencontainer\specs which does not compile on Windows. This needs merging here and vendoring into containerd to make any chance of starting forward progress.